Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Remove support for resolving modules by package directory path #11162

Merged
merged 1 commit into from
Apr 27, 2024
Merged

[red-knot] Remove support for resolving modules by package directory path #11162

merged 1 commit into from
Apr 27, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Follow-up to the module resolver work. As requested by carl ;)

Test Plan

cargo test

@MichaReiser MichaReiser changed the base branch from main to red-knot April 26, 2024 09:14
@MichaReiser MichaReiser requested a review from carljm April 26, 2024 09:14
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser merged commit 381a3bc into red-knot Apr 27, 2024
18 checks passed
@MichaReiser MichaReiser deleted the modules-remove-by-dir-resolution branch April 27, 2024 07:08
MichaReiser added a commit that referenced this pull request Apr 27, 2024
@MichaReiser
[red-knot] Remove support for resolving modules by package directory …
4d7d3b2 
…path (#11162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @carljm