red-knot: Cache symbol tables #11106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| where | ||
| Db: SemanticDb + HasJar<SemanticJar>, | ||
| { | ||
| let jar = db.jar(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
No, that's not it 😅 . It's a jar in which you store your salsa... And each jar contains multiple ingredients.
carljm
reviewed
Apr 23, 2024
|
I'll update this PR to cache |
0634caf to
a4da71a
Compare
carljm
approved these changes
Apr 24, 2024
|
a4da71a to
9837844
Compare
MichaReiser
added a commit
that referenced
this pull request
Apr 25, 2024
MichaReiser
added a commit
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
db.symbol_table(file_id)method that allows querying the symbol table for a file (that gets cached).Test Plan
cargo build