Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display-only fix is marked as fixable in the docs (ERA001) #9505

Closed
korchizhinskiy opened this issue Jan 13, 2024 · 1 comment · Fixed by #9649
Closed

Display-only fix is marked as fixable in the docs (ERA001) #9505

korchizhinskiy opened this issue Jan 13, 2024 · 1 comment · Fixed by #9649
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@korchizhinskiy
Copy link

image

https://docs.astral.sh/ruff/rules/#eradicate-era
This rule specify as fixable, but when i use --fix flag, errors don't fixes automaticly.
And there's no notification below the errors about fixable this error.
@charliermarsh
Copy link
Member

We probably shouldn't mark display-only fixes as fixable in the docs. \cc @zanieb

@charliermarsh charliermarsh added the bug Something isn't working label Jan 13, 2024
@charliermarsh charliermarsh changed the title select=ERA001 fixable Display-only fix is marked as fixable in the docs (ERA001) Jan 13, 2024
@charliermarsh charliermarsh self-assigned this Jan 26, 2024
@charliermarsh charliermarsh mentioned this issue Jan 26, 2024
Merged
charliermarsh added a commit that referenced this issue Jan 26, 2024
@charliermarsh
Avoid rendering display-only rules as fixable (#9649)
79a0ddc 
Closes #9505.

The `ERA` rule is no longer marked as fixable:

![Screenshot 2024-01-26 at 9 17
48 AM](https://github.com/astral-sh/ruff/assets/1309177/fdc6217f-38ff-4098-b6ca-37ff51b710ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid rendering display-only rules as fixable astral-sh/ruff
2 participants
@charliermarsh @korchizhinskiy