Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix error] UP025, UP032, W605 #8967

Closed
AlexBlandin opened this issue Dec 2, 2023 · 2 comments · Fixed by #8971
Closed

[Fix error] UP025, UP032, W605 #8967

AlexBlandin opened this issue Dec 2, 2023 · 2 comments · Fixed by #8971
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@AlexBlandin
Copy link

AlexBlandin commented Dec 2, 2023 •
edited
Loading

Using ruff check --select UP025,UP032,W605 --fix --isolated pokedex/doc/tabledoc.py on a local copy of the https://github.com/veekun/pokedex repo reports Ruff introducing a syntax error. So, this seems to be an issue with Unicode literals in f-strings?
@charliermarsh charliermarsh added the bug Something isn't working label Dec 2, 2023
@charliermarsh
Copy link
Member

Thanks!

@charliermarsh
Copy link
Member

Minimum snippet: u'foo\ bar'

@charliermarsh charliermarsh self-assigned this Dec 2, 2023
@charliermarsh charliermarsh mentioned this issue Dec 2, 2023
Merged
charliermarsh added a commit that referenced this issue Dec 2, 2023
@charliermarsh
Avoid syntax error via invalid ur string prefix (#8971)
1dda669 
## Summary

If a string has a Unicode prefix, we can't add the `r` prefix on top of
that -- we need to remove and replace it. (The Unicode prefix is
redundant anyway in Python 3.)

Closes #8967.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid syntax error via invalid ur string prefix astral-sh/ruff
2 participants
@charliermarsh @AlexBlandin