Skip to content

Commit

Permalink
make builtins_module a regular function, not a query
Browse files Browse the repository at this point in the history
  • Loading branch information
carljm committed Jul 18, 2024
1 parent ee6282d commit e6d5e35
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 2 additions & 3 deletions crates/red_knot_module_resolver/src/db.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
use ruff_db::Upcast;

use crate::resolver::{
builtins_module, editable_install_resolution_paths, file_to_module,
internal::ModuleNameIngredient, module_resolution_settings, resolve_module_query,
editable_install_resolution_paths, file_to_module, internal::ModuleNameIngredient,
module_resolution_settings, resolve_module_query,
};
use crate::typeshed::parse_typeshed_versions;

Expand All @@ -12,7 +12,6 @@ pub struct Jar(
module_resolution_settings,
editable_install_resolution_paths,
resolve_module_query,
builtins_module,
file_to_module,
parse_typeshed_versions,
);
Expand Down
2 changes: 0 additions & 2 deletions crates/red_knot_module_resolver/src/resolver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ pub(crate) fn resolve_module_query<'db>(
/// Salsa query to return the Module for builtins.
///
/// Can return None if a custom typeshed is used that has no `builtins.pyi`.
#[allow(unreachable_pub)]
#[salsa::tracked]
pub fn builtins_module(db: &dyn Db) -> Option<Module> {
let _span = tracing::trace_span!("resolve_builtins").entered();

Expand Down

0 comments on commit e6d5e35

Please sign in to comment.