Add to other branch

astral-sh · Nov 4, 2023 · 0f92719 · 0f92719
1 parent 1ddc272
commit 0f92719
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/crates/ruff_linter/src/rules/pycodestyle/rules/type_comparison.rs b/crates/ruff_linter/src/rules/pycodestyle/rules/type_comparison.rs
@@ -138,6 +138,7 @@ fn deprecated_type_comparison(checker: &mut Checker, compare: &ast::ExprCompare)
                         | "list"
                         | "dict"
                         | "set"
+                        | "memoryview"
                 ) && checker.semantic().is_builtin(id)
                 {
                     checker.diagnostics.push(Diagnostic::new(

diff --git a/...src/rules/pycodestyle/snapshots/ruff_linter__rules__pycodestyle__tests__E721_E721.py.snap b/...src/rules/pycodestyle/snapshots/ruff_linter__rules__pycodestyle__tests__E721_E721.py.snap
@@ -20,6 +20,16 @@ E721.py:5:4: E721 Do not compare types, use `isinstance()`
 7 | #: E721
   |
 
+E721.py:8:4: E721 Do not compare types, use `isinstance()`
+   |
+ 6 |     pass
+ 7 | #: E721
+ 8 | if type(res) == memoryview:
+   |    ^^^^^^^^^^^^^^^^^^^^^^^ E721
+ 9 |     pass
+10 | #: Okay
+   |
+
 E721.py:18:4: E721 Do not compare types, use `isinstance()`
    |
 16 | import types