-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension is showing warnings about configuration issues in pyproject.toml files in a .venv #478
Comments
Does this only appear when you open a file in Pandas, like Go-To Definition into Pandas itself? Or always? |
(Agree we shouldn't show you this.) |
This shows up when I open the mono-repo project (w/h opening any files in the VSCode window) so it seems to be triggered by the initialization phase. I've attached the start of the log (after opening the project) below:
The above statement is repeated for every project, then it shows the following lines:
Let me know if additional information is useful! |
Thanks, I see the issue. We proactively discover all configuration files, and we're not respecting exclusions. |
Fixed in astral-sh/ruff#11551. |
## Summary Right now, we're discovering configuration files even within (e.g.) virtual environments, because we're recursing without respecting the `exclude` field on parent configuration. Closes astral-sh/ruff-vscode#478. ## Test Plan Installed Pandas; verified that I saw no warnings: ![Screenshot 2024-05-26 at 8 09 05 PM](https://github.com/astral-sh/ruff/assets/1309177/dcf4115c-d7b3-453b-b7c7-afdd4804d6f5)
Hi,
I've enabled the new Ruff LSP and I saw the following output in the logs:
A quick look at the pandas repo does show that they should indeed update their pyproject.toml however as a user this information is not actionable or relevant.
Since we're using a mono-repo with a number of installation of pandas this does create a bit of noise but is otherwise not an issue.
To reproduce:
The text was updated successfully, but these errors were encountered: