Upgrade tcl/tk from 8.6.12 to 8.6.14 on Unix #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's stay modern. Should address #296.
Required for missing `UTType`
7e541ab to
85714a1
Compare
zanieb
commented
Jan 14, 2025
Comment on lines
+337
to
+343
| "tk-windows-bin": { | ||
| "url": "https://github.com/python/cpython-bin-deps/archive/c624cc881bd0e5071dec9de4b120cbe9985d8c14.tar.gz", | ||
| "size": 9497943, | ||
| "sha256": "9b8e77d55f40ceaedd140ccca0daa804f0d43346d5abfcead9b547b5590f82f8", | ||
| "version": "8.6.14", | ||
| "git_commit": "c624cc881bd0e5071dec9de4b120cbe9985d8c14", | ||
| }, |
There was a problem hiding this comment.
This updated, but not used here yet.
Gankra
approved these changes
Jan 14, 2025
Comment on lines
-241
to
+244
| ("riscv64-unknown-linux-gnu", vec!["ld-linux-riscv64-lp64d.so.1", "libatomic.so.1"]), | ||
| ( | ||
| "riscv64-unknown-linux-gnu", | ||
| vec!["ld-linux-riscv64-lp64d.so.1", "libatomic.so.1"], | ||
| ), |
There was a problem hiding this comment.
i started at this a bunch hoping to win at Spot The Difference That Makes It Longer So rustfmt Rewraps It but i lost. weird.
There was a problem hiding this comment.
Yeah I have no clue. I just accepted it.
This was referenced Jan 14, 2025
Closed
zanieb
added a commit
that referenced
this pull request
Jan 14, 2025
The upstream build system now requires the latest tcl/tk and we want to upgrade anyway, so that happens here as well. There are some concerns about the new zlib/msvcrt dependencies, so I'm limiting these to the 3.14a to see how it goes. See #495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #313 to only apply to Unix. We'll handle Windows separately in #494.