Avoid incorrect triple match for substrings #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given an artifact like
cpython-3.8.19-x86_64-pc-windows-msvc-shared-pgo-20240401T1106.tar.gz, we were matching against the triplex86_64-pc-windows-msvc(rather thanx86_64-pc-windows-msvc-shared); so the release code then assumed that the install suffix wasshared-pgorather thanpgo, and failed to align the assets.This should fix both of the issues described in #244, since the hard-float armv7 triples are also prefixes of the non-hard-float variants (
armv7-unknown-linux-gnueabihfvs.armv7-unknown-linux-gnueabi).Test Plan
Ran
just releasewith these local changes (skipping uploads); verified that no missing-file errors were raised.