Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation for lint, format, and type check #245

Merged
merged 6 commits into from
Apr 14, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Apr 1, 2024

Follows #236 (comment)

Adds a check.py script and splits some requirements into requirements.dev.in / .txt. Enforces checks in a CI job.

Runs:

  • ruff check with a very limited selection of rules, can add more later
  • ruff format
  • mypy on a subset of modules

A --fix flag can be provided to apply linter fixes and reformat files.

Copy link
Collaborator

@indygreg indygreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was long overdue. Thank you for doing this!

@indygreg indygreg merged commit d09ff92 into astral-sh:main Apr 14, 2024
238 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants