Changed observables attribute-update logic to use dom.attr

astoilkov · Nov 1, 2016 · 8937239 · 8937239
1 parent df176f0
commit 8937239
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/src/query/observable.js b/src/query/observable.js
@@ -187,8 +187,6 @@ define([
           var element;
           var offset;
           var value;
-          var isProperty;
-          var propertyName;
           var rawValue;
 
           Observer.startObserving();
@@ -213,21 +211,14 @@ define([
 
             offset = expression.length - value.length;
             expression.length = value.length;
-            // @todo remove duplicated logic instead use dom.* methods
-            isProperty = dom.props[expression.attr];
-            propertyName = expression.attr ? dom.propFix[expression.attr.toLowerCase()] || expression.attr : null;
 
             if (element) {
               if (blocks.isObservable(rawValue) && rawValue._expressions.indexOf(expression) == -1) {
                   rawValue._expressions.push(expression);
               }
 
               if (expression.attr) {
-                if(isProperty) {
-                  element[propertyName] = Expression.GetValue(context, null, expression.entire);
-                } else {
-                  element.setAttribute(expression.attr, Expression.GetValue(context, null, expression.entire));
-                }
+                  dom.attr(element, expression.attr, Expression.GetValue(context, null, expression.entire));
               } else {
                 if (element.nextSibling) {
                   element = element.nextSibling;