Allow printing a command-line equivalent of a command #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based, based on #172. |
8d41290 to
9cd09e2
Compare
matt-mazzucato
requested changes
Mar 7, 2023
utils/cmdline.go
Outdated
Comment on lines
77
to
82
| func MaybeCurlAndExit(req client.AstarteRequest, client *client.Client) { | ||
| if viper.GetBool("appengine-to-curl") || viper.GetBool("housekeeping-to-curl") || viper.GetBool("pairing-to-curl") || viper.GetBool("realmmanagement-to-curl") { | ||
| fmt.Println(req.ToCurl(client)) | ||
| os.Exit(0) | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of duplicating the implementation, why not
Suggested change
| func MaybeCurlAndExit(req client.AstarteRequest, client *client.Client) { | |
| if viper.GetBool("appengine-to-curl") || viper.GetBool("housekeeping-to-curl") || viper.GetBool("pairing-to-curl") || viper.GetBool("realmmanagement-to-curl") { | |
| fmt.Println(req.ToCurl(client)) | |
| os.Exit(0) | |
| } | |
| } | |
| func MaybeCurlAndExit(req client.AstarteRequest, client *client.Client) { | |
| MaybeCurl(req, client) | |
| os.Exit(0) | |
| } |
There was a problem hiding this comment.
That's no good because MaybeCurlAndExit would exit even if all *-to-curl are false. Using something like
func ShouldCurl() bool {
return viper.GetBool("appengine-to-curl") || viper.GetBool("housekeeping-to-curl") || viper.GetBool("pairing-to-curl") || viper.GetBool("realmmanagement-to-curl")
}instead of that condition might be a better solution, though.
cmd/appengine/device.go
Outdated
| @@ -571,6 +581,9 @@ func devicesDataSnapshotF(command *cobra.Command, args []string) error { | |||
| if err != nil { | |||
| warnOrFail(snapshotInterface, i.Name, err) | |||
| } | |||
|
|
|||
| utils.MaybeCurl(snapshotCall, astarteAPIClient) | |||
There was a problem hiding this comment.
Not sure if we want to print the equivalent curl and run the request.
We should consider a more robust approach
cmd/realm/interfaces.go
Outdated
| @@ -333,6 +349,9 @@ func getInterfaceDefinition(realm, interfaceName string, interfaceMajor int) (in | |||
| return interfaces.AstarteInterface{}, err | |||
| } | |||
|
|
|||
| // don't care about `interface sync` because its flag is always false | |||
There was a problem hiding this comment.
Is this comment relevant? (check also the ones below)
There was a problem hiding this comment.
It is relevant, but a bit too obscure. Will reword.
Add the `--to-curl` flag to print get a bash command equivalent to the one astartectl would run. If the flag is set, astartectl will take no futher action. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
matt-mazzucato
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--to-curlflag to allow the user to get a bash command equivalent to the one astartectl would run.If the flag is set, astartectl will take no futher action.
Closes #100.