[Enhancement] TBA instructors #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated i ^0.3.5 => ^0.3.7
Co-authored-by: Jeremy Cherer <chererjeremy@gmail.com>
Template was crashing because of improper usage of the Ember if-statement, and emails for classes without instructors were not being sent out because of a nonsensical and totally useless condition in the else statement. Instructor-rosters.js was also crashing because the if-statement was attempting to access a non-existant property instructors.email, now checks for instructors before checking for instructors.email
JavaLavaMT
reviewed
Dec 9, 2021
JavaLavaMT
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
Action
Requesting to merge branch
enhancement/#73-tba-instructorsintoepic/training-room-registrationDescription
New notification email will be sent to administrators if any classes/webinars have not yet been assigned an instructor two days prior to the class commencing. Updated administrator list and added support for ember-helpers, specifically the inflect-text helper.
Images
[ New Feature ]
hub-admin-instructor-tba.hbs