forceFlag was never used to recreate client with the new access token #76
Conversation
| @@ -95,7 +95,7 @@ protected int poll() throws Exception { | |||
| postProcess(fileModel, file); | |||
| } | |||
| } catch (GoogleJsonResponseException e) { | |||
| LOG.error("Google Drive Consume error:", e); | |||
| LOG.info(" >> GoogleJsonResponseException occurred"); | |||
| service = this.endpoint.getClient(true); | |||
There was a problem hiding this comment.
Not good to set an exception in an info log. Better to change it into a warning. Also, when you get this as user, you want to have more info. I would suggest something like this (pseudocode):
if(connectionAttempts < 60){
LOG.warn("Could not connect to Google Drive directory + directory. Try again after x seconds (attempt " + connectionAttempts + " of 60)");
connectionAttempts += 1;
service = this.endpoint.getClient(true);
}else{
LOG.error("GoogleJsonResponseException occurred. Connect to Google Drive directory + directory failed:", e);
}
There was a problem hiding this comment.
x = the poll interval. The user can change the poll interval to try it for a longer period.
There was a problem hiding this comment.
changes done!
x = should be the delay parameter set by the user
| @@ -72,7 +76,8 @@ public boolean isSingleton() { | |||
| } | |||
|
|
|||
| Drive getClient(boolean forceFlag) { | |||
| if (client == null) { | |||
| if (client == null || forceFlag) { | |||
| LOG.info(" >> Get client"); | |||
There was a problem hiding this comment.
This line doesn't say that much. Either leave it away or provide more info what's going on:
LOG.info("Get GoogleDrive client with clientid=" + );
| @@ -22,6 +24,8 @@ | |||
| @SuppressWarnings("PackageAccessibility") | |||
| public class GoogleDriveEndpoint extends ProcessorEndpoint { | |||
|
|
|||
| private static final Logger LOG = LoggerFactory.getLogger(GoogleDriveEndpoint.class); | |||
|
|
|||
There was a problem hiding this comment.
There's a more generic (and I think recommended way) to get the logger:
protected Logger log = LoggerFactory.getLogger(getClass());
There was a problem hiding this comment.
deleted line. don't need anymore
No description provided.