Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML to JSON legacy component - corrections/refinements #74

Merged
merged 23 commits into from
Jan 4, 2024
Merged

XML to JSON legacy component - corrections/refinements #74

merged 23 commits into from
Jan 4, 2024

Conversation

brunovg
Copy link
Collaborator

@brunovg brunovg commented Jan 3, 2024

No description provided.

brunovg added 23 commits November 10, 2023 14:32
@brunovg
use attribute names from Contants class
be9b718
@brunovg
correction how the attributes names are added on object node
aecbfca
@brunovg
added more unit tests
cfbe197
@brunovg
included test unit examples 17 to 26
ff4a722
@brunovg
testing some changes on xml to json conversion
40ddee9
@brunovg
by default do nothing. when it's a null in the string, set value as null
de6ae23
@brunovg
include string attribute type as default option, and use attribute ty…
966b953 
…pe lowercase on setValueUsingAttributeType. check node size with a switch on extractChildAsOtherInObjectNode
@brunovg
if subNode is empty, then set empty array node in rootObjectNode
deaaef3
@brunovg
an xml node that contains text and attributes, converts ok to json, w…
e97b363 
…hen using typeHints
@brunovg
if attribute type is empty, act as string. if something else, do nothing
1fc8ada
@brunovg
methods to check if siblings/children have the same name
b0cbf60
@brunovg
using areSiblingsNamesEqual info on TextNodeTransaction
1eede80
@brunovg
extracting attribute type info by Element or using directly by value
45e8cee
@brunovg
set empty array node in rootObjectNode only if there's no type attrib…
40ab38d 
…ute and value is null
@brunovg
added test unit 27
8436f6a
@brunovg
new argument grandParentClass added in the main method convertXmlToJs…
fe24c79 
…on(). improved logic to comply the latest unit tests.
@brunovg
added more unit tests
e2dc829
@brunovg
refined logic on OtherTypeWithoutNamespace to extractChildAsOtherInOb…
76bbb0f 
…jectNode
@brunovg
refined logic on RootArrayType to use recursive call convertXmlToJson…
7cfb9d6 
… instead extractChildAsArray
@brunovg
refined logic on OtherType to use #text when type attribute is not null
c729a70
@brunovg
refined login on method isRootArray
9691784
@brunovg
refined method getElementName, do not use skipNamespaces in the if logic
2b8729a
@brunovg
multiple refinements/corrections
f9fad2b
@brunovg brunovg added the bug Something isn't working label Jan 3, 2024
@brunovg brunovg added this to the 4.0.5 milestone Jan 3, 2024
@brunovg brunovg requested a review from skin27 January 3, 2024 20:00
@brunovg brunovg self-assigned this Jan 3, 2024
@brunovg brunovg linked an issue Jan 3, 2024 that may be closed by this pull request
XML to Json legacy component - failing in some cases #68
Closed
skin27
skin27 reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@skin27 skin27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty complex, but well done!

@skin27 skin27 merged commit c653c69 into develop Jan 4, 2024
@skin27 skin27 deleted the 68-xml-to-json-legacy-component-failing-in-some-cases branch January 4, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skin27 skin27 skin27 left review comments

Assignees

@brunovg brunovg

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.

XML to Json legacy component - failing in some cases
2 participants
@brunovg @skin27