Add EfCoreTransactionStrategy to share transactions

[diogodamiani]

Hi @hikalkan,

I've implemented the EfCoreTransactionStrategy based on EfTransactionStrategy. It fix #1829.

One thing I don't know if it's good enough: The connection is propagated through AbpDbContextConfiguration. At Startup we should do the following:

services.AddAbpDbContext<MyDbContext>(options => { 
    if (options.Connection == null)
        DbContextOptionsConfigurer.Configure(
            options.DbContextOptions, options.ConnectionString);
    else
        DbContextOptionsConfigurer.Configure(
            options.DbContextOptions, options.Connection);
});

The Configure method should have an overload for DbConnection:

public static class DbContextOptionsConfigurer
{
    public static void Configure(
        DbContextOptionsBuilder<SimpleTaskAppDbContext> dbContextOptions, 
        string connectionString
        )
    {
        /* This is the single point to configure DbContextOptions for MyDbContext */
        dbContextOptions.UseSqlServer(connectionString);
    }

    public static void Configure(
        DbContextOptionsBuilder<SimpleTaskAppDbContext> dbContextOptions, 
        DbConnection connection
        )
    {
        /* This is the single point to configure DbContextOptions for MyDbContext */
        dbContextOptions.UseSqlServer(connection);
    }
}

I'll appreciate your review. Thank you!

P.S.: I would like to thank @alexandrejose for the collaboration in the development! :)

[hikalkan]

Thanks a lot. I will review it.

[hikalkan]

Thank you very much. It's well designed. I merged and will be released with v1.5.0. I will continue to review it and will refactor if needed.

[hikalkan]

I will make a few changes if it works: #1909

[hikalkan]

So, it's better to check ExistingConnection before (renamed from Connection):

            Configuration.Modules.AbpEfCore().AddDbContext<MyDbContext>(options =>
            {
                if (options.ExistingConnection != null)
                {
                    options.DbContextOptions.UseSqlServer(options.ExistingConnection);
                }
                else
                {
                    options.DbContextOptions.UseSqlServer(options.ConnectionString);
                }
            });

[brunobertechini]

@hikalkan One thing with given solution is :

options.DbContextOptions.UseSqlServer(options.ConnectionString);

Always return the "Default" conn string. Is there any way to register my custom dbcontext conn string different from Default ?

Right now I am using the following approach:

IHostingEnvironment env = IocManager.Resolve<IHostingEnvironment>();
var connString = env.GetAppConfiguration().GetConnectionString(BusinessIntelligenceConsts.ConnectionStringName);
BusinessIntelligenceDbContextConfigurer.Configure(configuration.DbContextOptions, connString);

And now i will try to apply the given solution and try to resolve #2325

[acjh]

Is there any way to register my custom dbcontext conn string different from Default ?

See https://aspnetboilerplate.com/Pages/Documents/Entity-Framework-Core:

So, where to set default connection string?

In Module PreInitialize

You can do it in PreInitialize of your module as shown below:

public class MyEfCoreAppModule : AbpModule
{
    public override void PreInitialize()
    {
        Configuration.DefaultNameOrConnectionString = GetConnectionString("Default");
        ...
    }
}

So, you can define GetConnectionString method simply returns the connection string from a configuration file (generally from appsettings.json).

[brunobertechini]

@acjh This will work for main app conn string.

I have 5 modules each with its own conn string.

Or are you suggesting extending the configuration for each module ?

[hikalkan]

Is there any way to register my custom dbcontext conn string different from Default?

You should implement and replace IConnectionStringResolver. In this custom service you can check dbcontext type (or other logic) to determine connection string dynamically.

DbPerTenantConnectionStringResolver (https://github.com/aspnetboilerplate/module-zero/blob/dev/src/Abp.ZeroCore.EntityFrameworkCore/Zero/EntityFrameworkCore/DbPerTenantConnectionStringResolver.cs) changes it to dynamically determine connection string per tenant.