This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
SlackCommand.ParseParameters(...) -> TryParseParameters(...)
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #231 - avoid returning a `ValueTuple` and hitting dotnet/standard#567 - reenable tests skipped in #232
rynowak
reviewed
Jan 24, 2018
| /// </returns> | ||
| public static (IDictionary<StringSegment, IList<StringSegment>> Parameters, string Error) ParseParameters( | ||
| StringSegment text) | ||
| public static IDictionary<StringSegment, IList<StringSegment>> TryParseParameters( |
There was a problem hiding this comment.
consider converting this to a bool TryParseParameters(text, out paramters, out errorMessage)
I usually expect a bool when I see Try.
I don't think it's super important
There was a problem hiding this comment.
Went with your not "super important" leaning, partially because the double-out part looks icky and partially to avoid redoing the doc comments yet again.
rynowak
approved these changes
Jan 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlackCommand.ParseParameters(...)to not return aValueTuple#231ValueTupleand hitting .NET Standard issues on .NET Framework 4.7.1 dotnet/standard#567