Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

Update Moq to 4.11.0 #1462

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Update Moq to 4.11.0 #1462

merged 1 commit into from
Oct 9, 2018

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Oct 9, 2018

This is the latest version of Moq, should have a fix for
dotnet/aspnetcore#3569

This is the latest version of Moq, should have a fix for
dotnet/aspnetcore#3569
@rynowak rynowak requested a review from natemcmaster October 9, 2018 00:01
@rynowak rynowak requested a review from JunTaoLuo as a code owner October 9, 2018 00:01
@rynowak
Copy link
Member Author

rynowak commented Oct 9, 2018

To verify this, I ran this locally with MVC. MVC has pretty substantial usage of Moq

@natemcmaster natemcmaster requested a review from Eilon October 9, 2018 16:17
@natemcmaster
Copy link
Contributor

cc @Eilon for OSS approval

Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super approved!

@rynowak
Copy link
Member Author

rynowak commented Oct 9, 2018

@natemcmaster @ryanbrandenburg - any advice about these cool build failures:

D:\a\1\s\build\repo.targets(229,5): error : The SDK 'Internal.AspNetCore.Sdk' specified could not be found. > D:\a\1\s\modules\Mvc\src\Microsoft.AspNetCore.Mvc.RazorPages\Microsoft.AspNetCore.Mvc.RazorPages.csproj [D:\a.dotnet\buildtools\korebuild\2.2.0-preview2-20181004.6\KoreBuild.proj]
2018-10-09T16:30:39.7512999Z D:\a\1\s\build\repo.targets(229,5): error : The SDK 'Internal.AspNetCore.Sdk' specified could not be found. > D:\a\1\s\modules\Scaffolding\test\VS.Web.CG.EFCore.Test\VS.Web.CG.EFCore.Test.csproj [D:\a.dotnet\buildtools\korebuild\2.2.0-preview2-20181004.6\KoreBuild.proj]
2018-10-09T16:30:43.5434313Z Finished design-time build in 45311ms

@ryanbrandenburg
Copy link
Contributor

@natemcmaster thinks we've fixed it with #1469.

@rynowak rynowak merged commit 0a1c60e into release/2.2 Oct 9, 2018
@rynowak rynowak deleted the rynowak/update-moq branch October 9, 2018 20:41
@natemcmaster
Copy link
Contributor

Um, where do we get Moq 4.11? The latest on nuget.org is 4.10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants