This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Allow overriding the hosting service provider #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the tests to verify that service providers are created and disposed - Called CreateBuilder even in the default case in case the service collection is modified as part of it.
Tratcher
approved these changes
Jan 31, 2018
| @@ -202,6 +202,22 @@ public IWebHost Build() | |||
| host.Dispose(); | |||
| throw; | |||
| } | |||
|
|
|||
| IServiceProvider GetProviderFromFactory(IServiceCollection collection) | |||
There was a problem hiding this comment.
Only used once and not complex, inline.
There was a problem hiding this comment.
I think it should remain a method. It's not like it's 2 lines of code. It's a few.
ENikS
reviewed
Jan 31, 2018
|
|
||
| // Don't bother calling CreateBuilder since it just returns the default service collection | ||
| applicationServiceProvider = serviceProviderFactory.CreateServiceProvider(services); | ||
| var builder = serviceProviderFactory.CreateBuilder(services); |
There was a problem hiding this comment.
Is it guaranteed that factory exists? What if serviceProviderFactory is null?
There was a problem hiding this comment.
This has been the case since 2.0. There’s always one registered. Unless somebody removes it.
There was a problem hiding this comment.
shrug it's a weird use of embedded methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1322