Support for json arrays + some rewrite #186
Conversation
|
|
||
| namespace Microsoft.Framework.ConfigurationModel | ||
| { | ||
| public class ConfigurationPathComparer : IComparer<string> |
There was a problem hiding this comment.
Is PathComparer the right name here? Should it not be Key comparer?
There was a problem hiding this comment.
It doesn't just compare individual keys. It can compare full config paths like settings:address:ip:0. See the unit tests for it
There was a problem hiding this comment.
I think path is a concept used by JSON.NET and we don't have such a concept in our configuration system. settings:address:ip:0 is a key in our understanding.
There was a problem hiding this comment.
Ok, will rename to ConfigurationKeyComparer
|
Updated |
|
|
- Use the json.net parser instead of manually parsing the json - Simplified some test code
2370f6a to
0517eee
Compare
| @@ -39,5 +39,6 @@ | |||
| [assembly: AssemblyVersion("1.0.0.0")] | |||
| [assembly: AssemblyFileVersion("1.0.0.0")] | |||
| [assembly: InternalsVisibleTo("Microsoft.Framework.ConfigurationModel.Test")] | |||
| [assembly: InternalsVisibleTo("Microsoft.Framework.ConfigurationModel.Json.Test")] | |||
There was a problem hiding this comment.
IVT is to be used only for the unit test assembly of this assembly. Make the type(s) in question public and move to a .Internal namespace.
There was a problem hiding this comment.
See the PR that fixes this: #188
|
How do I read an array configuration value that's stored in |
|
@weitzhandler check out the various |
|
@Eilon |
|
@weitzhandler ah, those got renamed. See aspnet/Announcements#33. |
Fixes #115
cc @ChengTian @lodejard @glennc @anurse