Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Typeform OAuth provider #897

Merged

Conversation

denis-goncharenko
Copy link
Contributor

This feature allows users to authenticate using their Typeform credentials. Tested in production service and works perfectly.

@martincostello martincostello added this to the 8.0.1 milestone Jun 13, 2024
@kevinchalet
Copy link
Member

Thanks a lot for your contributions, @denis-goncharenko! ❤️

Would you be interested in porting these providers to OpenIddict (that we now recommend for new applications)?

The process is a bit more elaborate but it shouldn't require writing custom code as these providers seem fairly standard (you'd just need to update the built-in MapCustomWebServicesFederationClaims handler to map the provider-specific claims to their ClaimTypes equivalent: https://documentation.openiddict.com/guides/contributing-a-new-web-provider.html#if-the-provider-doesnt-support-standard-openid-connect-userinfo-map-the-provider-specific-claims-to-their-claimtypes-equivalent)

@denis-goncharenko
Copy link
Contributor Author

Thanks a lot for your contributions, @denis-goncharenko! ❤️

Would you be interested in porting these providers to OpenIddict (that we now recommend for new applications)?

The process is a bit more elaborate but it shouldn't require writing custom code as these providers seem fairly standard (you'd just need to update the built-in MapCustomWebServicesFederationClaims handler to map the provider-specific claims to their ClaimTypes equivalent: https://documentation.openiddict.com/guides/contributing-a-new-web-provider.html#if-the-provider-doesnt-support-standard-openid-connect-userinfo-map-the-provider-specific-claims-to-their-claimtypes-equivalent)

It's quite interesting to me. I am considering porting these providers to OpenIddic in the near future.

@martincostello martincostello merged commit e2d2ced into aspnet-contrib:dev Jun 14, 2024
8 checks passed
@martincostello
Copy link
Member

Thanks for your contribution @denis-goncharenko - all four of the new providers are now available as part of version 8.1.0.

@kevinchalet

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants