-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Airtable OAuth provider #895
Implement Airtable OAuth provider #895
Conversation
Also, I've tested the Airtable provider against the production service and can confirm that it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments?
Are you planning on any other PRs to add more providers other than these 2, as if so I'll hold any release until they're all completed and merged.
src/AspNet.Security.OAuth.Airtable/AirtableAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Airtable/AirtableAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Airtable/AirtableAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Airtable/AirtableAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
I am going to add 2 more providers in one-two days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 👍🏻
requestMessage.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue(MediaTypeNames.Application.Json)); | ||
requestMessage.Content = new FormUrlEncodedContent(tokenRequestParameters); | ||
requestMessage.Headers.Authorization = CreateAuthorizationHeader(); | ||
requestMessage.Version = Backchannel.DefaultRequestVersion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea (we could also set the VersionPolicy
property), but it looks like we haven't been very consistent regarding that as only 4 providers seem to set it.
@denis-goncharenko would you be interested in sending a PR to fix the inconsistency? (either by setting it for all the providers or by removing it for the 4 that currently use it, which would be less work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it. I will set it for all providers next week in a separate PR.
This feature allows users to authenticate using their Airtable credentials.