Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Airtable OAuth provider #895

Merged

Conversation

denis-goncharenko
Copy link
Contributor

This feature allows users to authenticate using their Airtable credentials.

@denis-goncharenko
Copy link
Contributor Author

Also, I've tested the Airtable provider against the production service and can confirm that it works fine.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments?

Are you planning on any other PRs to add more providers other than these 2, as if so I'll hold any release until they're all completed and merged.

@denis-goncharenko
Copy link
Contributor Author

Just a few minor comments?

Are you planning on any other PRs to add more providers other than these 2, as if so I'll hold any release until they're all completed and merged.

I am going to add 2 more providers in one-two days.

@martincostello martincostello added this to the 8.0.1 milestone Jun 13, 2024
Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍🏻

requestMessage.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue(MediaTypeNames.Application.Json));
requestMessage.Content = new FormUrlEncodedContent(tokenRequestParameters);
requestMessage.Headers.Authorization = CreateAuthorizationHeader();
requestMessage.Version = Backchannel.DefaultRequestVersion;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea (we could also set the VersionPolicy property), but it looks like we haven't been very consistent regarding that as only 4 providers seem to set it.

@denis-goncharenko would you be interested in sending a PR to fix the inconsistency? (either by setting it for all the providers or by removing it for the 4 that currently use it, which would be less work)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it. I will set it for all providers next week in a separate PR.

@martincostello martincostello merged commit b6c69ec into aspnet-contrib:dev Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants