Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pipedrive OAuth provider #892

Merged

Conversation

denis-goncharenko
Copy link
Contributor

This feature allows users to authenticate using their Pipedrive credentials.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments - I assume you've tested this provider works against the production Pipedrive service?

@denis-goncharenko
Copy link
Contributor Author

Just a few minor comments - I assume you've tested this provider works against the production Pipedrive service?

I've tested the Pipedrive provider against the production service and can confirm that it works fine.

@martincostello martincostello added this to the 8.0.1 milestone Jun 12, 2024
@martincostello
Copy link
Member

Thanks for the contribution - the changes look good. I'll look to merge this later today (or tomorrow) when I have some time to put aside to manage the release.

Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@martincostello martincostello merged commit 3be27ad into aspnet-contrib:dev Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants