Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the new LinkedIn API version format #834

Merged

Conversation

softwareolatomiwa
Copy link
Contributor

@softwareolatomiwa softwareolatomiwa commented Mar 1, 2024

New Apps created on LinkedIn returns with Error 403 on getting user details using the /me endpoint. The endpoint has been changed and scope also has been changed to include openid, profile and email

ALso the format of user data returned has changed.

https://www.linkedin.com/developers/news/featured-updates/openid-connect-authentication

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

This PR needs work before we can accept it due to the breaking nature of the changes to the library's public API surface and other changes to the test code that were not necessary.

@softwareolatomiwa softwareolatomiwa changed the title Dev linkedin updated scopes Support of the new LinkedIn API version format Mar 1, 2024
@softwareolatomiwa softwareolatomiwa changed the title Support of the new LinkedIn API version format Support for the new LinkedIn API version format Mar 1, 2024
@@ -6,6 +6,7 @@

using System.Security.Claims;
using System.Text.Json;
using Microsoft.Extensions.Options;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this is needed for anything?

@martincostello martincostello added this to the 8.0.1 milestone Mar 3, 2024
@martincostello
Copy link
Member

Can you also confirm that this all works as expected with the real live LinkedIn API?

@kevinchalet
Copy link
Member

Given it's technically a behavior breaking change - that requires subscribing to the new OIDC-based service - it would probably make more sense to bump the minor version (i.e 8.1 instead of 8.0.1). We'll also need to mention that clearly in the release notes.

@softwareolatomiwa
Copy link
Contributor Author

@martincostello I confirm it works as expected with the real live LinkedIn API

@thang-d
Copy link

thang-d commented Jun 12, 2024

Hi @martincostello
I think we should complete it ASAP; we are having trouble with LinkedIn authentication

@martincostello
Copy link
Member

It would probably make more sense to bump the minor version (i.e 8.1 instead of 8.0.1).

@kevinchalet So do you want to re-version everything as 8.1.0 for releasing this?

@kevinchalet
Copy link
Member

@kevinchalet So do you want to re-version everything as 8.1.0 for releasing this?

Yeah, that would be better.

In the same vein, we should probably bump the minor version instead of the patch version when introducing new features/providers: only bumping the patch version is something we had to do when ASP.NET Core had minor versions (as we wanted to have matching major+minor versions), but it's no longer necessary now that .NET never increases its minor version.

@martincostello
Copy link
Member

OK - once I merge the open PRs, I'll do a follow up to update 8.0.1 to 8.1.0 before doing the release, and then I'll do patch or minor going forwards depending on what's in the release.

@martincostello martincostello merged commit 22fe33a into aspnet-contrib:dev Jun 14, 2024
8 checks passed
@martincostello
Copy link
Member

Thanks for your contribution @softwareolatomiwa - these changes are now available in version 8.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

LinkedIn Authentication Fails Add support of the new LinkedIn API version format
4 participants