Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Autodesk Auth to new v2 API endpoints #788

Closed
wants to merge 3 commits into from

Conversation

ClaysonIO
Copy link

Autodesk is deprecating their v1 Auth API endpoints, per the following blog post: https://aps.autodesk.com/blog/authentication-v2-and-deprecation-v1

This PR updates the URLs, and adjusts the claims to match the new userInfo API response, per the following documentation links:

Autodesk is deprecating the v1 APIs, and moving to v2. 

Updates where claims are sourced from using the new APIs, as documented at https://aps.autodesk.com/en/docs/oauth/v2/reference/http/userinfo-GET/

Note that the 2fa claim is removed due to the informatio no longer being provided by the Autodesk API.
Update endpoint URLs in AutodeskAuthenticationDefaults.cs to v2
@kevinchalet
Copy link
Member

Thanks for your PR!

One thing: their documentation explicitly mentions that for v2 token requests, the client credentials must now be sent as part of the Authorization header (aka client_secret_basic), which also seems to be confirmed by the fact their OIDC discovery document doesn't list client_secret_post as a supported client authentication method: https://developer.api.autodesk.com/.well-known/openid-configuration

Did you have a chance to test against the real implementation? Are we sure client_secret_post still works?

@kevinchalet
Copy link
Member

I forgot we already had a PR open to update the Autodesk, sorry. Feel free to join the discussion: #764.

@kevinchalet
Copy link
Member

Are we sure client_secret_post still works?

For the record, I just gave it a try and it indeed doesn't work: client_secret_post is no longer supported:

{
  "error": "invalid_credentials",
  "error_description": "The client credentials are invalid."
}

I see you work for Autodesk as a Senior Technical Consultant ; do you happen to know why this change was made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants