Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Huawei provider. #742

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Conversation

vicenteyu
Copy link
Contributor

Add Huawei provider.

image

QQ截图20221028211334

2022-10-28

Signed-off-by: Vicente Yu <^@^>
Copy link
Contributor

@kinosang kinosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

Vicente Yu added 2 commits October 29, 2022 20:55
Signed-off-by: Vicente Yu <^@^>
Signed-off-by: Vicente Yu <^@^>
@martincostello martincostello added this to the 6.0.13 milestone Nov 1, 2022
Vicente Yu added 2 commits November 1, 2022 21:35
Signed-off-by: Vicente Yu <^@^>
Signed-off-by: Vicente Yu <^@^>
@martincostello martincostello merged commit cd594d9 into aspnet-contrib:dev Nov 1, 2022
@martincostello
Copy link
Member

@vicenteyu Sorry, forgot to ask before I merged this. Have you verified that the provider works as expected against the actual Huawei services in a running application?

@vicenteyu
Copy link
Contributor Author

vicenteyu commented Nov 1, 2022

@vicenteyu Sorry, forgot to ask before I merged this. Have you verified that the provider works as expected against the actual Huawei services in a running application?

Yes. It works fine.

image

@vicenteyu vicenteyu deleted the dev_huawei branch November 1, 2022 14:39
@martincostello
Copy link
Member

Thanks again for your contribution - the package is now available from NuGet.org: https://www.nuget.org/packages/AspNet.Security.OAuth.Huawei/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants