-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Huawei provider. #742
Add Huawei provider. #742
Conversation
Signed-off-by: Vicente Yu <^@^>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments.
src/AspNet.Security.OAuth.Huawei/AspNet.Security.OAuth.Huawei.csproj
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Huawei/AspNet.Security.OAuth.Huawei.csproj
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Huawei/HuaweiAuthenticationDefaults.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Vicente Yu <^@^>
Signed-off-by: Vicente Yu <^@^>
src/AspNet.Security.OAuth.Huawei/HuaweiAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Vicente Yu <^@^>
Signed-off-by: Vicente Yu <^@^>
@vicenteyu Sorry, forgot to ask before I merged this. Have you verified that the provider works as expected against the actual Huawei services in a running application? |
Yes. It works fine. |
Thanks again for your contribution - the package is now available from NuGet.org: https://www.nuget.org/packages/AspNet.Security.OAuth.Huawei/ |
Add Huawei provider.