Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitter provider #644

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

martincostello
Copy link
Member

Add an OAuth 2.0 Twitter provider.

@kevinchalet
Copy link
Member

There's already an OAuth 1.0 provider in ASP.NET Core, is there a particular reason to have an OAuth 2.0 provider here? Is there a migration plan that will obsolete OAuth 1.0 at some point?

@martincostello
Copy link
Member Author

Check out dotnet/aspnetcore#39664.

Copy link

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martincostello
Copy link
Member Author

@kevinchalet Thoughts on this? dotnet/aspnetcore#39664 (comment)

Assuming you're happy aspnet-core will keep shipping the OAuth 1.0 provider until whenever, and we'll be the OAuth 2.0 version and sort of "pick up the baton" over time as the Twitter API evolves.

@kevinchalet
Copy link
Member

Assuming you're happy aspnet-core will keep shipping the OAuth 1.0 provider until whenever, and we'll be the OAuth 2.0 version and sort of "pick up the baton" over time as the Twitter API evolves.

No objection.

@Tratcher in return, I'd be interested in seeing more contributions from the ASP.NET team: with roughly ~80 packages, this repository is an absolute beast and @martincostello already dedicates a lot of time to it (PR reviews, code and infrastructure maintenance, not to mention the tweaks needed to react to changes introduced in ASP.NET Core itself).

I suspect you - and Hao who's also familiar with the authentication stack - already have a busy schedule and to be 100% clear, I'm not suggesting you guys should do that in your free time, but that would be great if your respective PMs could take that into account to let you contribute to aspnet-contrib from time to time (e.g by triaging issues, reviewing/testing the submitted providers or by keeping the infra/Arcade up-to-date).

@martincostello martincostello added this to the 6.0.3 milestone Jan 21, 2022
@martincostello martincostello marked this pull request as ready for review January 21, 2022 21:44
Add an OAuth 2.0 Twitter provider.
@martincostello martincostello merged commit 55c7c11 into aspnet-contrib:dev Jan 22, 2022
@martincostello martincostello deleted the Twitter-OAuth2 branch January 22, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants