Use NuGet.exe instead of dotnet nuget #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build workflow relies on
dotnet nuget pushto push NuGet packages to MyGet.org/NuGet.org.While the .NET SDK is generally present on most GitHub workers,
actions/setup-dotnet@v1is called quite early to install a fixed .NET SDK version that will be exclusively used for pushing packages (since .NET Arcade takes care of installing the SDK and runtimes listed in global.json). On Windows workers, this step can take up to 50 seconds:This PR replaces
actions/setup-dotnet@v1bynuget/setup-nuget@v1- that typically runs in less than a second - and updates the 2 "Push NuGet packages" steps to useNuGet.exe: