-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 6 #623
Merged
Merged
Update to .NET 6 #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the providers to .NET 6, using new language features and APIs as appropriate.
martincostello
commented
Nov 4, 2021
Update the solution file to require Visual Studio 2022.
Use "preview" not "rc.2".
Update Arcade to the same version as used to build the v6.0.0 tag for dotnet/aspnetcore.
martincostello
commented
Nov 5, 2021
<LangVersion>latest</LangVersion> | ||
<NoWarn>$(NoWarn);CS1591</NoWarn> | ||
<!-- TODO Actually resolve this by using the logging source generator --> | ||
<NoWarn>$(NoWarn);CA1848</NoWarn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
martincostello
commented
Nov 5, 2021
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix> | ||
<!-- TODO Baseline to 6.0.0 once released --> | ||
<PackageValidationBaselineVersion>5.0.17</PackageValidationBaselineVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove custom NuGet feeds to packages for .NET 6 are sourced from NuGet.org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the providers to .NET 6, using new language features and APIs as appropriate.
This pull request takes the current state of the
dev-6.0.0
branch (as of 9f06be8) and squashes it down into a single commit to get rid of months of merges fromdev
and all the preview and RC release commits/history.Use of file-scoped namespaces is limited to the sample app only, I plan to do a follow-up PR post-merge to adopt them for all the code files using
dotnet format
to fix them up separately. Otherwise the diff would be...a bit much 😄Once .NET 6 binaries are available in NuGet.org, I just need to remove the custom NuGet feeds and then this should be good to come out of draft and be merged.
Notable changes
Notable commits from the original
dev-6.0.0
branch squashed down here include:RandomNumberGenerator.GetBytes()
9427fdbJsonSerializer.SerializeToDocument()
85e18fdContributes to #552.