Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 6 #623

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Conversation

martincostello
Copy link
Member

Update the providers to .NET 6, using new language features and APIs as appropriate.

This pull request takes the current state of the dev-6.0.0 branch (as of 9f06be8) and squashes it down into a single commit to get rid of months of merges from dev and all the preview and RC release commits/history.

Use of file-scoped namespaces is limited to the sample app only, I plan to do a follow-up PR post-merge to adopt them for all the code files using dotnet format to fix them up separately. Otherwise the diff would be...a bit much 😄

Once .NET 6 binaries are available in NuGet.org, I just need to remove the custom NuGet feeds and then this should be good to come out of draft and be merged.

Notable changes

Notable commits from the original dev-6.0.0 branch squashed down here include:

  • Use System.Text.Json.Node a012b1b
  • Use ConfigurationManager in Apple provider 886b3ae
  • Make constants fields 023d2fb 2d970cb
  • Remove claim for Discord avatar a25c2ee
  • Simplify PEM loading in Apple provider a5a5b5d
  • Use RandomNumberGenerator.GetBytes() 9427fdb
  • Use JsonSerializer.SerializeToDocument() 85e18fd
  • Use implicit using statements 9559742
  • Use file-scoped namespaces in sample app (not in the providers) 6b94a82

Contributes to #552.

Update the providers to .NET 6, using new language features and APIs as appropriate.
@martincostello martincostello added this to the 6.0.0 milestone Nov 4, 2021
eng/Versions.props Outdated Show resolved Hide resolved
NuGet.config Outdated Show resolved Hide resolved
Directory.Build.props Show resolved Hide resolved
eng/Version.Details.xml Outdated Show resolved Hide resolved
global.json Outdated Show resolved Hide resolved
Update the solution file to require Visual Studio 2022.
Use "preview" not "rc.2".
Update Arcade to the same version as used to build the v6.0.0 tag for dotnet/aspnetcore.
<LangVersion>latest</LangVersion>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<!-- TODO Actually resolve this by using the logging source generator -->
<NoWarn>$(NoWarn);CA1848</NoWarn>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<!-- TODO Baseline to 6.0.0 once released -->
<PackageValidationBaselineVersion>5.0.17</PackageValidationBaselineVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove custom NuGet feeds to packages for .NET 6 are sourced from NuGet.org.
@martincostello martincostello marked this pull request as ready for review November 8, 2021 07:46
@martincostello martincostello merged commit 2cd3c25 into aspnet-contrib:dev Nov 8, 2021
@martincostello martincostello deleted the DotNet-6 branch November 8, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant