Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always publish logs and test results #452

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Always publish logs and test results #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:

- name: Publish logs
uses: actions/upload-artifact@v1
if: ${{ always() }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. What does that mean for the actions that execute after a step decorated with if: ${{ always() }}? Do they execute even if the first step - but not the previous one - failed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just applies to the specific step you decorate. The default if you don't specify anything is that it calls success(): docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks 👏

with:
name: logs-${{ matrix.os_name }}
path: ./artifacts/log/Release
Expand All @@ -72,6 +73,7 @@ jobs:

- name: Publish test results
uses: actions/upload-artifact@v1
if: ${{ always() }}
with:
name: testresults-${{ matrix.os_name }}
path: ./artifacts/TestResults/Release
Expand Down