Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using IdentityModel's ConfigurationManager in the Apple provider #421

Closed
kevinchalet opened this issue May 6, 2020 · 3 comments · Fixed by #561
Closed

Consider using IdentityModel's ConfigurationManager in the Apple provider #421

kevinchalet opened this issue May 6, 2020 · 3 comments · Fixed by #561
Assignees
@martincostello
Labels
enhancement
Milestone
6.0.0

Comments

@kevinchalet
Copy link
Member

Apple now supports standard OIDC provider discovery (https://appleid.apple.com/.well-known/openid-configuration), so we could muchly simplify our keys retrieval and caching story by using IdentityModel's ConfigurationManager.

Since it will likely require adopting API breaking changes, it's probably something that will have to wait until 5.0.

Related: #417 (comment)
@martincostello
Copy link
Member

Ah nice to see them embrace some standards 😄

@martincostello
Copy link
Member

Something to look into for .NET 6.0 now.

@martincostello martincostello self-assigned this Feb 2, 2021
@martincostello martincostello added this to the 6.0.0 milestone Jun 5, 2021
martincostello added a commit to martincostello/AspNet.Security.OAuth.Providers that referenced this issue Jun 5, 2021
@martincostello
Use ConfigurationManager in Apple provider
decc1d6 
Switch to using the ConfigurationManager and Apple's OpenID Connect discovery endpoint instead of the custom implementation.
Also changes PrivateKeyBytes to accept a CancellationToken.
Resolves aspnet-contrib#421.
@martincostello martincostello mentioned this issue Jun 5, 2021
Merged
martincostello added a commit to martincostello/AspNet.Security.OAuth.Providers that referenced this issue Jun 5, 2021
@martincostello
Use ConfigurationManager in Apple provider
1439821 
Switch to using the ConfigurationManager and Apple's OpenID Connect discovery endpoint instead of the custom implementation.
Also changes PrivateKeyBytes to accept a CancellationToken.
Resolves aspnet-contrib#421.
martincostello added a commit that referenced this issue Jun 7, 2021
@martincostello
Use ConfigurationManager in Apple provider
15523d2 
Switch to using the ConfigurationManager and Apple's OpenID Connect discovery endpoint instead of the custom implementation.
Also changes PrivateKeyBytes to accept a CancellationToken.
Resolves #421.
@martincostello
Copy link
Member

Will be included in the 6.0.0 release later this year.

@martincostello martincostello linked a pull request Jun 7, 2021 that will close this issue
Use ConfigurationManager in Apple provider #561
Merged
martincostello added a commit that referenced this issue Jun 17, 2021
@martincostello
Use ConfigurationManager in Apple provider
9307fe7 
Switch to using the ConfigurationManager and Apple's OpenID Connect discovery endpoint instead of the custom implementation.
Also changes PrivateKeyBytes to accept a CancellationToken.
Resolves #421.
martincostello added a commit that referenced this issue Jul 4, 2021
@martincostello
Use ConfigurationManager in Apple provider
886b3ae 
Switch to using the ConfigurationManager and Apple's OpenID Connect discovery endpoint instead of the custom implementation.
Also changes PrivateKeyBytes to accept a CancellationToken.
Resolves #421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martincostello martincostello

Labels
enhancement
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Use ConfigurationManager in Apple provider martincostello/AspNet.Security.OAuth.Providers
2 participants
@martincostello @kevinchalet