Create settings link for the plugin in the plugin listing page

[namithj]

Pull Request

What changed?

Create settings link for the plugin in the plugin listing page

Why did it change?

Add settings link for the plugin in the plugin listing page for ease of use

Did you fix any specific issues?

#295

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

[afragen]

There's no need to remove then re-add hr deactivate link. Simply use an array_merge() and put the settings first.

Settings usually comes first or last in the links array.

[namithj]

Putting settings link first would simplify things but I checked a few plugins and they seem to retain the deactivate link in the first position.

If you have a plugin like PCP it adds the "check plugin" link to the end, making the settings link go to the last position when we add it.

Forcing it just after the deactivate seemed like a better choice. I do see a bug though with multisite when there might not be a deactivate link at all for some users. So we need to update the logic to check if there is a deactivate link and then swap OR just put the settings link at the beginning without complicating things.

[costdev]

Unless I'm mistaken, I think @afragen is suggesting this instead:

$settings_url = network_admin_url( 'index.php?page=aspireupdate-settings' );
return array_merge(
  [
    'settings' => '<a href="' . esc_url( $settings_url ) . '">' . __( 'Settings', 'aspireupdate' ) . '</a>',
  ],
  $links
);

And leaving deactivate wherever it is, if it's in the $links array at all (which would avoid the multisite issue too)

[costdev]

To my knowledge, there's no established best practice for which order a settings link appears. It's mostly more important that it's in there at all.

[namithj]

Yes, we can do that. No need to complicate it further by adding a check for deactivate link.