fix: ensure ts_project _types target has the right visibility #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is not passed, the _types target will get the package's default visibility.
In out case, we have a package with a very restrictive visibility, but one of the targets (
ts_project
) in the package is explicitly set topublic
. We want to depend on the_types
target, but that is not visible due the default visibility.NOTE: This is relevant only when an
dts
emitter is provided.Changes are visible to end-users: yes
Test plan
Create a target with a
dts
emitter. Ensure the_types
target gets the same visibility of the main target.