Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure ts_project _types target has the right visibility #766

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

menny
Copy link
Contributor

@menny menny commented Jan 22, 2025

If this is not passed, the _types target will get the package's default visibility.

In out case, we have a package with a very restrictive visibility, but one of the targets (ts_project) in the package is explicitly set to public. We want to depend on the _types target, but that is not visible due the default visibility.
NOTE: This is relevant only when an dts emitter is provided.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
    Create a target with a dts emitter. Ensure the _types target gets the same visibility of the main target.

If this is not passed, the _types target will get the package's default visibility
Copy link

aspect-workflows bot commented Jan 22, 2025

Test

All tests were cache hits

163 tests (100.0%) were fully cached saving 16s.


Buildifier      Format

@jbedard jbedard changed the title Ensure _types target has the right visibility fix: ensure ts_project _types target has the right visibility Jan 22, 2025
@jbedard jbedard enabled auto-merge (squash) January 22, 2025 22:54
@jbedard
Copy link
Member

jbedard commented Jan 22, 2025

Thanks for the fix 👍

@jbedard jbedard merged commit 9acdfa1 into aspect-build:main Jan 22, 2025
20 checks passed
@menny
Copy link
Contributor Author

menny commented Jan 22, 2025

wow. that was quick :)

@menny menny deleted the patch-1 branch January 22, 2025 22:59
@jbedard
Copy link
Member

jbedard commented Jan 22, 2025

The notification basically popped up under my mouse, and lgtm lol 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants