Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable RBE testing #531

Merged
merged 3 commits into from
Jan 27, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: re-enable RBE testing
  • Loading branch information
alexeagle committed Jan 27, 2024
commit d37e284dc4e4490544b8d871c74e7e88a3c9dbb5
2 changes: 1 addition & 1 deletion .github/workflows/ci.bazelrc
Original file line number Diff line number Diff line change
@@ -37,4 +37,4 @@ build:rbe --remote_executor=grpcs://remote.buildbuddy.io
# We are using RBE to test that the actions we create in rules_ts will work for our customers,
# not to accelerate and parallelize the builds for unrelated actions that happen to appear in our dependencies.
# So, turn off RBE for actions that are known to be problematic because they are non-hermetic.
build:rbe --modify_execution_info=CppCompile=+no-remote-exec,CppLink=+no-remote-exec,GenProtoDescriptorSet=+no-remote-exec
build:rbe --modify_execution_info=CppCompile=+no-remote-exec,CppLink=+no-remote-exec,GenProtoDescriptorSet=+no-remote-exec,ProtocGenEs=+no-remote-exec
1 change: 1 addition & 0 deletions ts/private/ts_proto_library.bzl
Original file line number Diff line number Diff line change
@@ -42,6 +42,7 @@ def _protoc_action(ctx, proto_info, outputs, options = {
progress_message = "Generating .js/.d.ts from %{label}",
outputs = outputs,
inputs = inputs,
mnemonic = "ProtocGenEs",
arguments = [args],
tools = [ctx.executable.protoc_gen_es] + (
[ctx.executable.protoc_gen_connect_es] if ctx.attr.has_services else []
Loading