Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for project-references examples (if supported) #163

Closed
rc-glean opened this issue Oct 3, 2022 · 2 comments · Fixed by #176
Closed

Request for project-references examples (if supported) #163

rc-glean opened this issue Oct 3, 2022 · 2 comments · Fixed by #176
Assignees
@alexeagle
Labels
question This issue is a question. Close the loop with documentation?

Comments

@rc-glean
Copy link

rc-glean commented Oct 3, 2022 •
edited
Loading

It's unclear to me whether https://www.typescriptlang.org/docs/handbook/project-references.html (incremental builds) are supported by just looking at the examples https://github.com/aspect-build/rules_ts/tree/d5842963bae0c1f0e83a77dabee595784418917b/examples.

I would have expected an example with multiple tsconfig.json's, with some tsconfig.json's referring to other tsconfig.json's via the references config (https://www.typescriptlang.org/tsconfig#references)

My main goal is to get yarn workspaces working with typescript and bazel

Edit: TLDR, my question is whether aspect ts rules support project-references
@cgrindel cgrindel added the question This issue is a question. Close the loop with documentation? label Oct 5, 2022
@alexeagle alexeagle mentioned this issue Oct 10, 2022
Open
@alexeagle
Copy link
Member

This is part of #23 - we should copy over https://github.com/bazelbuild/rules_nodejs/tree/stable/packages/typescript/test/ts_project/c which shows project references.

@alexeagle alexeagle self-assigned this Oct 12, 2022
@alexeagle
Copy link
Member

I reproduced that error you mentioned in microsoft/TypeScript#37378 (comment)

The cause is that in a refactoring we lost these two lines
https://github.com/bazelbuild/rules_nodejs/blob/stable/nodejs/private/ts_project.bzl#L87-L88
which were the way that the tsconfig.json file of a referenced composite project was being provided as an input to tsc.

alexeagle added a commit that referenced this issue Oct 12, 2022
@alexeagle
fix: allow composite projects
08e4467 
We need to propagate the tsconfig.json file to composite project dependents as an input.
This was in rules_nodejs but we lost it.

Also correct the pathing for the tsbuildinfo output, which hadn't been tested in rules_ts yet.

Copied the three composite projects from rules_nodejs tests, so we have that coverage now.

Fixes #163
@alexeagle alexeagle mentioned this issue Oct 12, 2022
Merged
alexeagle added a commit that referenced this issue Oct 12, 2022
@alexeagle
fix: allow composite projects
d39b164 
We need to propagate the tsconfig.json file to composite project dependents as an input.
This was in rules_nodejs but we lost it.

Also correct the pathing for the tsbuildinfo output, which hadn't been tested in rules_ts yet.

Copied the three composite projects from rules_nodejs tests, so we have that coverage now.

Fixes #163
alexeagle added a commit that referenced this issue Oct 12, 2022
@alexeagle
fix: allow composite projects
cb4cfbb 
We need to propagate the tsconfig.json file to composite project dependents as an input.
This was in rules_nodejs but we lost it.

Also correct the pathing for the tsbuildinfo output, which hadn't been tested in rules_ts yet.

Copied the three composite projects from rules_nodejs tests, so we have that coverage now.

Fixes #163
alexeagle added a commit that referenced this issue Oct 12, 2022
@alexeagle
fix: allow composite projects (#176)
87355ae 
We need to propagate the tsconfig.json file to composite project dependents as an input.
This was in rules_nodejs but we lost it.

Also correct the pathing for the tsbuildinfo output, which hadn't been tested in rules_ts yet.

Copied the three composite projects from rules_nodejs tests, so we have that coverage now.

Fixes #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
question This issue is a question. Close the loop with documentation?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow composite projects aspect-build/rules_ts
3 participants
@alexeagle @cgrindel @rc-glean