Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compat with Bazel 5 #68

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: compat with Bazel 5 #68

merged 1 commit into from
May 3, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented May 3, 2024 •
edited
Loading

The @@ syntax for canonical repo name did not exist

Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
alex@a:~/Projects/rules_aws/e2e/smoke$ USE_BAZEL_VERSION=5.4.0 bazel run @aws//:aws

Verified that command fails without this fix.

@alexeagle
chore: compat with Bazel 5
93554a0 
The @@ syntax for canonical repo name did not exist
@alexeagle alexeagle requested a review from CaerusKaru May 3, 2024 22:07
@alexeagle alexeagle merged commit 4a40fbb into main May 3, 2024
11 checks passed
@alexeagle alexeagle deleted the bucket branch May 3, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaerusKaru CaerusKaru CaerusKaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @CaerusKaru