test: mark as flaky according to the new policy

Closes microsoft#1300, microsoft#1303, microsoft#1305
aslushnikov · Mar 10, 2020 · fbb27ba · fbb27ba
1 parent 23cf3be
commit fbb27ba
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/test/browsercontext.spec.js b/test/browsercontext.spec.js
@@ -20,7 +20,7 @@ const utils = require('./utils');
 /**
  * @type {BrowserTestSuite}
  */
-module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FFOX, WEBKIT}) {
+module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FFOX, WEBKIT, LINUX}) {
   const {describe, xdescribe, fdescribe} = testRunner;
   const {it, fit, xit, dit} = testRunner;
   const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
@@ -420,8 +420,8 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FF
       expect(response.status()).toBe(200);
       await context.close();
     });
-    // flaky: https://github.com/microsoft/playwright/issues/1303
-    it.fail(FFOX)('should fail if wrong credentials', async({browser, server}) => {
+    // flaky: https://github.com/microsoft/playwright/pull/1301/checks?check_run_id=496478707
+    it.fail(FFOX && LINUX)('should fail if wrong credentials', async({browser, server}) => {
       server.setAuth('/empty.html', 'user', 'pass');
       const context = await browser.newContext({
         httpCredentials: { username: 'foo', password: 'bar' }

diff --git a/test/evaluation.spec.js b/test/evaluation.spec.js
@@ -22,7 +22,7 @@ const bigint = typeof BigInt !== 'undefined';
 /**
  * @type {PageTestSuite}
  */
-module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) {
+module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, LINUX}) {
   const {describe, xdescribe, fdescribe} = testRunner;
   const {it, fit, xit, dit} = testRunner;
   const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
@@ -230,8 +230,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
       await page.evaluate(e => e.textContent, element).catch(e => error = e);
       expect(error.message).toContain('JSHandle is disposed');
     });
-    it.fail(FFOX)('should simulate a user gesture', async({page, server}) => {
-      // Flaky on Limux: https://github.com/microsoft/playwright/issues/1305
+    // flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496501774
+    it.fail(FFOX && LINUX)('should simulate a user gesture', async({page, server}) => {
       const result = await page.evaluate(() => {
         document.body.appendChild(document.createTextNode('test'));
         document.execCommand('selectAll');

diff --git a/test/workers.spec.js b/test/workers.spec.js
@@ -21,14 +21,14 @@ const { waitEvent } = utils;
 /**
  * @type {PageTestSuite}
  */
-module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) {
+module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, LINUX}) {
   const {describe, xdescribe, fdescribe} = testRunner;
   const {it, fit, xit, dit} = testRunner;
   const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
 
   describe('Workers', function() {
-    // Flaky: https://github.com/microsoft/playwright/issues/1300
-    it.fail(FFOX)('Page.workers', async function({page, server}) {
+    // flaky: https://github.com/microsoft/playwright/pull/1297/checks?check_run_id=496348690
+    it.fail(FFOX && LINUX)('Page.workers', async function({page, server}) {
       await Promise.all([
         page.waitForEvent('worker'),
         page.goto(server.PREFIX + '/worker/worker.html')]);
@@ -102,8 +102,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
       expect(destroyed).toBe(true);
       expect(page.workers().length).toBe(0);
     });
-    // Flaky: https://github.com/microsoft/playwright/issues/1300
-    it.fail(FFOX)('should report network activity', async function({page, server}) {
+    // flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496461538
+    it.fail(FFOX && LINUX)('should report network activity', async function({page, server}) {
       const [worker] = await Promise.all([
         page.waitForEvent('worker'),
         page.goto(server.PREFIX + '/worker/worker.html'),