Change header text source from hardcode to package

askirmas · Aug 12, 2020 · 318b161 · 318b161
1 parent db3906e
commit 318b161
Show file tree

Hide file tree

Showing 10 changed files with 26 additions and 19 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -11,6 +11,12 @@
         "Andrii_Kirmas.json"
       ],
       "url": "./Andrii_Kirmas.schema.json"
+    },
+    {
+      "fileMatch": [
+        "nodemon.json"
+      ],
+      "url": "https://json.schemastore.org/nodemon"
     }
   ]
 }
diff --git a/Andrii_Kirmas.css b/Andrii_Kirmas.css
diff --git a/Andrii_Kirmas.html b/Andrii_Kirmas.html
diff --git a/cli/__image_snapshots__/Andrii_Kirmas-web-snap.png b/cli/__image_snapshots__/Andrii_Kirmas-web-snap.png
diff --git a/cli/pdf.test.ts b/cli/pdf.test.ts
@@ -17,7 +17,7 @@ beforeAll(async () => {
 })
 
 it("web", async () => {
-  await page.goto(`file://${cwd}/index.html`, {
+  await page.goto(`file://${cwd}/${fileName}.html`, {
     "waitUntil": "networkidle2"
   })
    await page.setViewport({ width: 1800, height: 980 })

diff --git a/index.html b/index.html
diff --git a/nodemon.json b/nodemon.json
@@ -1,5 +1,5 @@
 {
-  "watch": ["cli"],
-  "ext": "ts",
-  "exec": "ts-node ./cli/md.ts"
+  "watch": ["page"],
+  "ext": "ts,tsx,js,jsx,json",
+  "exec": "npm run compile/html"
 }
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@kirmas/cv",
   "version": "1.3.1",
-  "description": "Andrii Kirmas - Senior Software Engineer",
+  "description": "Andrii Kirmas - Senior Full Stack Software Engineer",
   "homepage": "https://askirmas.github.io/cv/",
   "main": "index.js",
   "bin": {
@@ -17,6 +17,7 @@
     "-compile/md": "npm run md --silent > ./Andrii_Kirmas.md",
     "compile/html": "ts-node --project page/tsconfig.json page/html.ts",
     "postcompile/html": "./absolutize.sh",
+    "html@dev": "nodemon",
     "-md": "ts-node cli/md.ts",
     "-md@dev": "nodemon",
     "sass@dev": "npm run sass -- --watch",

diff --git a/page/index.tsx b/page/index.tsx
@@ -2,6 +2,7 @@ import React from 'react'
 
 // type Part<T> = {[K in keyof T]: T[K] | undefined}
 type tProps = Partial<{
+  "name": string
   "description": string
   "email": string
   "phex": string
@@ -22,6 +23,7 @@ const {entries: $entries} = Object
 , langs = ["English","Hebrew","Ukrainian","Russian","JS"]
 
 export default function CvSlots({
+  name = "",
   description = "",
   email = "",
   phex = "",
@@ -44,8 +46,15 @@ export default function CvSlots({
     </head>
     <body>
       <header className="Main__header">
-        <div className="Main__title"></div>
-        <div className="Main__description"><a className="Term--Engineer" href="https://medium.com/shakuro/programmer-vs-developer-vs-engineer-91ef374e5033" title="The engineer has a solid educational grounding and the ability to apply engineering concepts to create digital solutions"></a></div>
+        <div className="Main__title">{name}</div>
+        <div className="Main__description">
+          {
+            description
+            .replace(name, "")
+            .replace(/(^[^\w]+|Engineer)/g, "")
+          }
+          <a className="Term--Engineer" href="https://medium.com/shakuro/programmer-vs-developer-vs-engineer-91ef374e5033" title="The engineer has a solid educational grounding and the ability to apply engineering concepts to create digital solutions"></a>
+        </div>
         <div className="Main__links">
           <div className="links_group">
             <a className="links links--email" href={`mailto:${email}`}>{email}</a>

diff --git a/styles/Andrii_Kirmas.scss b/styles/Andrii_Kirmas.scss
@@ -115,15 +115,6 @@ $font-bold: 600;
   }
 }
 
-.Main__ {
-  &title {
-    @include content-value("Andrii Kirmas");
-  }
-  &description{
-    @include content-key("Senior Software ");
-  }
-}
-
 .links-- {
   &residence {
     pointer-events: none;