Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint to 0.57.0 #204

Merged

Conversation

michaeleustace
Copy link
Contributor

Updates SwiftLint to 0.57.0

@ashfurrow
Copy link
Owner

Hi! Thanks for the PR! The change looks good – I just wanted to double-check the md5 signature but I got a different value. Which file did you use to get the hash? (I haven't updated it myself in a while either 😅)

@michaeleustace
Copy link
Contributor Author

Hi @ashfurrow. I noted that there were different possible hashes from the recent update to 0.55.1.

Therefore I used a modified version of the Rakefile and download script to download the latest portable_swiftlint.zip and then ran md5 -q on the downloaded zip to generate the hash in this PR.

I checked I was getting the correct md5 by using the same script to download the 0.55.1 version of portable_swiftlint.zip and running md5 gave me the same hash value as the one in the current release.

I hope this helps.

@ashfurrow
Copy link
Owner

@michaeleustace You're quite right! The docs are incorrect, but the implementation clearly shows the md5 sum from the zip file:

curl -s -L "${url}" -o "${asset}"
# If macOS
if [[ "$OSTYPE" == "darwin"* ]]; then
resulting_hash=`md5 -q ${asset}`
# Default to linux
else
resulting_hash=`md5sum ${asset} | awk '{ print $1 }'`
fi

I'll update the docs and tag you.

@ashfurrow ashfurrow merged commit e2891a4 into ashfurrow:master Oct 8, 2024
1 check passed
@ashfurrow-peril
Copy link

Thanks a lot for contributing @michaeleustace! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Owner

This change has been released in 0.37.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants