Skip to content

Commit

Permalink
Merge pull request #200 from aiKrice/master
Browse files Browse the repository at this point in the history
Updates Swiftlint to 0.55.1
  • Loading branch information
ashfurrow authored May 20, 2024
2 parents bf340a8 + ac9ee88 commit 6ef47ee
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## Current Master

- Nothing yet!
- Updates Swiftlint to 0.55.1. (use `additional_swiftlint_args: "--baseline additional_swiftlint_args: path/to/baseline.json")`
- Add a readme on How To Update Swiftlint version for this repository.

## 0.35.0

Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ Or, if you are behind a proxy or using a package manager which does not allow yo

Finally, if something's not working correctly, you can debug this plugin by using setting `swiftlint.verbose = true`.

## Contribution tips
### Upgrading Swiftlint to the latest version
Follow this guide -> [How-To-Upgrade-Swiftlint](/ext/swiftlint/README.md)

## Attribution

Original structure, sequence, and organization of repo taken from [danger-prose](https://github.com/dbgrandi/danger-prose) by [David Grandinetti](https://github.com/dbgrandi/).
Expand Down
27 changes: 27 additions & 0 deletions ext/swiftlint/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
## How to Upgrade Swiftlint

### Step 1: Find the hash of the new swiftlint binary
Go on the Swiftlint repo, download the latest archive and unzip it
On macos: execute a md5 against the `swiftint` binary
On linux: execute a md5sum against the `swiftint` binary
Save the hash

### Step 1: Clone this repository

### Step 2: Execute the rakefile
To fetch the latest hash version, you need to execute the rakefile in this folder

```bash
bundle install && rake

```

The hash is printed in the terminal (`-dh` value)

### Step 3: Open the PR
If you don't have errors on step 3, then you can open a PR by editing the file
`/lib/version.rb` and changing :
- SWIFTLINT_VERSION=${target_swiftlint_version}
- SWIFTLINT_HASH=${md5_hash}

Thank you for your contributions.
4 changes: 2 additions & 2 deletions lib/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module DangerSwiftlint
VERSION = '0.35.0'
SWIFTLINT_VERSION = '0.54.0'
SWIFTLINT_HASH = 'b3ced098efb95de601fba7c299fbb123'
SWIFTLINT_VERSION = '0.55.1'
SWIFTLINT_HASH = '506b49a6d71512b25a511bca01065503'
end

0 comments on commit 6ef47ee

Please sign in to comment.