extensions/amd: Add VK_AMD_anti_lag extension #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 tasks
Ralith
approved these changes
Sep 19, 2024
0d85622 to
8b35b04
Compare
8b35b04 to
dbaf77b
Compare
MarijnS95
commented
Dec 2, 2024
Comment on lines
+6
to
+10
| /// <https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkAntiLagUpdateAMD.html> | ||
| #[inline] | ||
| #[doc(alias = "vkAntiLagUpdateAMD")] | ||
| pub unsafe fn anti_lag_update(&self, data: &vk::AntiLagDataAMD<'_>) { | ||
| (self.fp.anti_lag_update_amd)(self.handle, data) |
There was a problem hiding this comment.
https://registry.khronos.org/vulkan/specs/latest/man/html/vkAntiLagUpdateAMD.html docs are a bit vague, they say:
If
pDatais not NULL...
Yet the respective VUID-vkAntiLagUpdateAMD-pData-parameter lacks the if `pData` is not `NULL`, `pData` must be a valid pointer to a valid... comment, as if it is not valid to leave this pointer NULL to begin with.
I'll leave it like this without Option and perhaps request a small spec update to remove the misleading is not NULL comment. CC @oddhack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.