Work around unused_qualifications lint for Rust 1.80 prelude extension
#931
Conversation
|
Never mind, The documentation is to blame here. https://doc.rust-lang.org/std/prelude/v1/index.html specifically mentions:
Followed by a list including And the module-level docs say:
Falsely giving the sense that this has always been in the prelude. |
4d2c612 to
e416ccd
Compare
`size_of(_val)()` was added to the prelude in Rust 1.80, causing `unused_qualifications` warnings whenever we import `mem` in scope and call it with `mem::` prefix. The easiest workaround is to remove the prefix and explicitly import the function(s) in scope, which was already done in a few places. We annotate the import with a `TODO` to remove it once bumping our MSRV on or past 1.80.
unused_qualifications lint (more strict since Rust 1.80)unused_qualifications lint for Rust 1.80 prelude extension
In #931 we worked around "unnecessary import" warnings for the `size_of(_val)()` functions being added to the prelude in Rust 1.80 while maintaining some form of MSRV back-compatibility (despite not testing the examples against this), but forgot about `align_of()`. This means the examples still build on Rust 1.80 or higher because `align_of()` is always in scope via the prelude there, but not on older compilers. Fix this by adding it to the import that's tagged to be removed when we bump all of `ash` to MSRV 1.80.
…955) In #931 we worked around "unnecessary import" warnings for the `size_of(_val)()` functions being added to the prelude in Rust 1.80 while maintaining some form of MSRV back-compatibility (despite not testing the examples against this), but forgot about `align_of()`. This means the examples still build on Rust 1.80 or higher because `align_of()` is always in scope via the prelude there, but not on older compilers. Fix this by adding it to the import that's tagged to be removed when we bump all of `ash` to MSRV 1.80.
size_of(_val)()was added to the prelude in Rust 1.80, causingunused_qualificationswarnings whenever we importmemin scope and call it withmem::prefix.The easiest workaround is to remove the prefix and explicitly import the function(s) in scope, which was already done in a few places. We annotate the import with a
TODOto remove it once bumping our MSRV on or past 1.80.