Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add proper_test_support_location/1 #18

Merged

Conversation

ibarakaiev
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

This PR adds proper_test_support_location/1, which returns idiomatic test support location such as MyApp.DataCase -> test/support/data_case.ex. It also inlines the tests as doctests for readability.

@zachdaniel
Copy link
Contributor

We should make a patcher that adds test/support to your libc directories, and then call it whenever you add a file into test/support.

@zachdaniel zachdaniel merged commit a6464db into ash-project:main Jun 26, 2024
15 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants