fix: remove shortnames for global options, to reduce conflicts

ash-project · Jul 9, 2024 · a6fb8ec · a6fb8ec
1 parent 913945b
commit a6fb8ec
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/lib/igniter/util/install.ex b/lib/igniter/util/install.ex
@@ -29,17 +29,19 @@ defmodule Igniter.Util.Install do
       end)
 
     global_options =
-      Igniter.Mix.Task.Info.global_options()
-      |> Keyword.update!(:switches, &Keyword.put(&1, :example, :boolean))
-      |> Keyword.update!(:aliases, &Keyword.put(&1, :e, :example))
+      Keyword.update!(
+        Igniter.Mix.Task.Info.global_options(),
+        :switches,
+        &Keyword.put(&1, :example, :boolean)
+      )
 
     {igniter, desired_tasks, {options, _}} =
       Igniter.Util.Info.compose_install_and_validate!(
         igniter,
         argv,
         %Igniter.Mix.Task.Info{
           schema: global_options[:switches],
-          aliases: global_options[:aliases],
+          aliases: [],
           installs: task_installs
         },
         "igniter.install"

diff --git a/lib/mix/task.ex b/lib/mix/task.ex
@@ -31,11 +31,8 @@ defmodule Igniter.Mix.Task do
         yes: :boolean,
         check: :boolean
       ],
-      aliases: [
-        d: :dry_run,
-        y: :yes,
-        c: :check
-      ]
+      # no aliases for global options!
+      aliases: []
     ]
 
     defstruct schema: [],
@@ -97,7 +94,6 @@ defmodule Igniter.Mix.Task do
           |> info(nil)
           |> Kernel.||(%Info{})
           |> Map.update!(:schema, &Keyword.merge(&1, global_options[:switches]))
-          |> Map.update!(:aliases, &Keyword.merge(&1, global_options[:aliases]))
 
         {opts, _} =
           Igniter.Util.Info.validate!(argv, info, Mix.Task.task_name(__MODULE__))

diff --git a/lib/mix/tasks/igniter.install.ex b/lib/mix/tasks/igniter.install.ex
@@ -19,9 +19,9 @@ defmodule Mix.Tasks.Igniter.Install do
 
   ## Switches
 
-  * `--dry-run` - `d` - Run the task without making any changes.
-  * `--yes` - `y` - Automatically answer yes to any prompts.
-  * `--example` - `e` - Request that installed packages include initial example code.
+  * `--dry-run` - Run the task without making any changes.
+  * `--yes` - Automatically answer yes to any prompts.
+  * `--example` - Request that installed packages include initial example code.
   """
   use Mix.Task