feat: adds store_inputs? true/false option
#29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: ash-project#20 - introduces `store_inputs?` to the DSL - `store_inputs?` if not included defaults to false - when switched on it ensure an attribute is created to capture the exact inputs of each new version, when the resource we are paper-trailing changes.
|
@rgraff let me know if this is what you had in mind, look at the test. I think you should be able to tell by that. |
zachdaniel
approved these changes
Oct 11, 2023
rgraff
reviewed
Oct 11, 2023
When we use `store_inputs? true` we store the original inputs of the change as map. Within this map all structs representing Ash Resources are converted into a map using `Ash.Type.dump_to_embedded/3`. We use the function `normalise_inputs/1` to do this which will deeply recurse within maps and lists to ensure all Ash Resource have been converted into their embedded counterpart.
This is a temporary measure, the eventual goal is to inspect each value in the inputs, if that value is sensitive then we'll redact it from the inputs stored in the version
…ords Co-authored-by: Robert Graff <robert@workingdemo.com>
zachdaniel
requested changes
Oct 12, 2023
| inputs = | ||
| changeset.attributes | ||
| |> Map.merge(changeset.arguments) | ||
| |> normalise_inputs() |
There was a problem hiding this comment.
We shouldn't do this by looking for structs, we should get the corresponding argument or attribute and use dump_to_embedded on it regardless of if the value is a struct or not.
There was a problem hiding this comment.
That will take care of the recursive aspect as well.
There was a problem hiding this comment.
Just this one open issue. Otherwise, looks good.
|
Closing for now due to inactivity, happy to revisit at a later point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #20
store_inputs?to the DSLstore_inputs?if not included defaults to false