Merge pull request #79 from aservo/fix-set-application-password

Applications: Fix setting password
aservo · May 29, 2024 · 304ab01 · 304ab01
2 parents f601a2d + ef4e9d0
commit 304ab01
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/main/java/de/aservo/confapi/crowd/service/ApplicationsServiceImpl.java b/src/main/java/de/aservo/confapi/crowd/service/ApplicationsServiceImpl.java
@@ -2,6 +2,7 @@
 
 import com.atlassian.crowd.embedded.api.Directory;
 import com.atlassian.crowd.embedded.api.OperationType;
+import com.atlassian.crowd.embedded.api.PasswordCredential;
 import com.atlassian.crowd.exception.*;
 import com.atlassian.crowd.manager.application.ApplicationManager;
 import com.atlassian.crowd.manager.application.ApplicationManagerException;
@@ -108,6 +109,11 @@ public ApplicationBean setApplication(
             final Application existingApplication = applicationManager.findById(id);
             final Application modifiedApplication = ApplicationBeanUtil.toApplication(applicationBean, existingApplication);
             final Application updatedApplication = applicationManager.update(modifiedApplication);
+
+            if (applicationBean.getPassword() != null) {
+                applicationManager.updateCredential(updatedApplication, PasswordCredential.unencrypted(applicationBean.getPassword()));
+            }
+
             persistApplicationDirectoryMappings(updatedApplication, applicationBean);
             persistApplicationBeanAuthenticationGroups(updatedApplication, applicationBean);
             persistApplicationBeanAutoAssignmentGroups(updatedApplication, applicationBean);

diff --git a/src/test/java/de/aservo/confapi/crowd/service/ApplicationsServiceTest.java b/src/test/java/de/aservo/confapi/crowd/service/ApplicationsServiceTest.java
@@ -134,6 +134,7 @@ public void testSetApplicationAllAttributes() throws ApplicationNotFoundExceptio
         requestApplicationBean.setName("Changed Name");
         requestApplicationBean.setDescription("Changed Description");
         requestApplicationBean.setActive(false);
+        requestApplicationBean.setPassword("password1");
         requestApplicationBean.setRemoteAddresses(Collections.singletonList("127.0.0.5"));
         Application application2 = toApplication(requestApplicationBean);
 
@@ -143,6 +144,7 @@ public void testSetApplicationAllAttributes() throws ApplicationNotFoundExceptio
         final ArgumentCaptor<Application> applicationCaptor = ArgumentCaptor.forClass(Application.class);
         applicationsService.setApplication(EXAMPLE_1.getId(), requestApplicationBean);
         verify(applicationManager).update(applicationCaptor.capture());
+        verify(applicationManager).updateCredential(any(), any());
         final Application updatedApplication = applicationCaptor.getValue();
 
         assertNotNull(updatedApplication);