Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode using utf-8 when casting to string #1

Closed
wants to merge 1 commit into from

Conversation

mrosanes
Copy link

@mrosanes mrosanes commented Mar 7, 2019

Fix bug. Encode models using utf-8, instead of a hard cast
to string, in order to allow curves addition to a plot.

Fix bug. Encode models using utf-8, instead of a hard cast
to string, in order to allow curves addition to a plot.
@mrosanes
Copy link
Author

mrosanes commented Mar 7, 2019

Hi @asenchenko; this pull request, together with a minor change proposed to taurus taurus-org/taurus#878, should allow to add curves to a taurus_pyqtgraph plot with python2 and python3.

If you agree with it, could you integrate it?

@asenchenko
Copy link
Owner

asenchenko commented Mar 15, 2019

Hi @mrosanes! Thank you. PR taurus-org/taurus/pull/878 fixes problem with adding curve to plot.
As i understand, your PR should solve problem with empty table in Curve Selection dialog.
I think that QByteArray should be casted to bytes and than to unicode.

@cpascual
Copy link

I think that QByteArray should be casted to bytes and than to unicode.

I agree with @asenchenko. His commit seems a better approach to me. So I suggest to close this PR

@asenchenko asenchenko closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants