remove uses of asdf metaschema #1249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is used extensively in jwst, so removing the usage here won't allow removal of the metaschema from asdf-standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asdf metaschema: https://github.com/asdf-format/asdf-standard/blob/master/resources/schemas/stsci.edu/asdf/asdf-schema-1.0.0.yaml
appears to only be used in a few tests and is no longer used in the ndarray schema. Modifying the tests to use the other included metaschema: https://github.com/asdf-format/asdf-standard/blob/master/resources/schemas/stsci.edu/yaml-schema/draft-01.yaml
does not result in any test failures (locally). Removal of the asdf metaschema (which contains a reference to the ndarray schema version 1.0 which contains a bug) will simplify the fix for ndarray schema bug: asdf-format/asdf-standard#345