Update to new Poetry Install Script #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crflynn
reviewed
Jun 12, 2021
|
Thanks for working on this. Does It work already? Does still try install 1.1.17 |
|
I believe that is correct, 1.1.17 is the latest release, 1.2.0a1 is a beta release and probably is not installed unless explicitly requested. Try |
|
Yes, the "latest" selector has an implementation on the asdf side that is intended to avoid rc and beta. |
|
Thank you. That makes complete sense of course. And yes it worked as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8.
Update the plugin to use the new poetry install script (https://python-poetry.org/blog/announcing-poetry-1.2.0a1/#deprecation-of-the-get-poetrypy-script). The new script is python3 only and no longer attempts to modify
$PATH.I've also unset the
PIP_REQUIRE_VIRTUALENVvariable during poetry install. The environmental variable shouldn't need to be unset, that is a bug, see python-poetry/poetry#4089 for more details.