Disable automatic logging of invalid refs and enable it via verbose m… #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exactly. |
mojavelinux
reviewed
Oct 10, 2018
| @@ -135,6 +136,9 @@ public void log(LogRecord logRecord) { | |||
| }; | |||
| asciidoctor.registerLogHandler(logHandler); | |||
|
|
|||
| // Asciidoctor currently only logs invalid refs if this global var is set | |||
| JRubyRuntimeContext.get().evalScriptlet("$VERBOSE=true"); | |||
There was a problem hiding this comment.
Doesn't this need to be unset again after the test is run? Or do tests not share the JRuby runtime context?
There was a problem hiding this comment.
It should be fine, hopefully.
Every Asciidoctor instance gets its own JRuby instance and should have it's own global state if I am not wrong.
But definitely sth to retest.
…hen mode is not set
|
Added a second test to ensure that invalid refs log messages are not created by default. I don't really like it, but also ensured that this test runs after the first that shows that $VERBOSE results in these messages being created to prove that the $VERBOSE global variable doesn't leak into other Asciidoctor instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode from CLI
This PR disables the automatic activation of the verbose mode again and thus disables logging of invalid refs.
The
-vargument for the CLI additionally enables this again.Therefore integrators have to run the Ruby script
$VERBOSE=truethemselves before rendering documents.@mojavelinux Is this what you had in mind?